PHP: Add OTEL support #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jduo
reviewed
Nov 7, 2025
jduo
reviewed
Nov 7, 2025
jduo
reviewed
Nov 7, 2025
jduo
reviewed
Nov 7, 2025
jduo
reviewed
Nov 7, 2025
jduo
reviewed
Nov 7, 2025
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
22 tasks
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
requested a deployment
to
AWS_ACTIONS
GitHub Actions
In progress
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jduo
reviewed
Nov 24, 2025
jduo
reviewed
Nov 24, 2025
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
…yConfigBuilder.php and OpenTelemetryConfig.php Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
Signed-off-by: Prateek Kumar <[email protected]>
prateek-kumar-improving
had a problem deploying
to
AWS_ACTIONS
GitHub Actions
Error
jduo
approved these changes
Nov 25, 2025
currantw
approved these changes
Nov 25, 2025
Collaborator
currantw
left a comment
currantw
left a comment
There was a problem hiding this comment.
Thanks @prateek-kumar-improving.
Approved ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
This Pull Request is linked to issue (URL): valkey-io/valkey-glide#4588
Description
The PHP client provides a complete OpenTelemetry integration for distributed tracing and observability of Valkey operations.
Key Features:
• Static API: Simple static methods on ValkeyGlide and ValkeyGlideCluster classes
• Sampling Control: Configurable percentage-based sampling (0-100%)
• Manual Span Management: Create and end spans for custom tracing
• Process-Level Initialization: Initialize once per PHP process
Files Created:
• valkey_glide_otel.h - Header definitions
• valkey_glide_otel.c - Core implementation
• ValkeyGlideFeaturesTest.php, ValkeyGlideClusterFeaturesTest.php and tests/TestValkeyGlide.php - Tests
• Config classes.
Files Modified:
• valkey_glide.stub.php & valkey_glide_cluster.stub.php - Added method signatures
• valkey_glide.c and valkey_glide_cluster.c
• config.m4 - Build system integration
• package.xml - PECL distribution manifest
Checklist
Before submitting the PR make sure the following are checked: