-
Notifications
You must be signed in to change notification settings - Fork 111
Java: jedis-compatibility add lib name in config.toml file #4843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Java: jedis-compatibility add lib name in config.toml file #4843
Conversation
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
Signed-off-by: Prateek Kumar <[email protected]>
path = "../src/lib.rs" | ||
|
||
[dependencies] | ||
redis = { path = "../../glide-core/redis-rs/redis", features = ["aio", "tokio-comp", "connection-manager", "tokio-rustls-comp"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are all dependencies duplicated in jedis-compatibility/Cargo.toml?
Since src/lib.rs
just includes the main client code, the jedis-compatibility crate should simply depend on glide-rs
as a library dependency. Cargo will automatically resolve all transitive dependencies.
This would eliminate the need to maintain duplicate dependency lists and reduce the risk of version mismatches.
} | ||
|
||
doFirst { | ||
// Clean Rust build to ensure fresh compilation with correct GLIDE_NAME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cargo clean
in the doFirst block defeats incremental compilation and significantly slows down builds.
If the goal is to ensure GLIDE_NAME is picked up correctly, the proper solution is to configure the Cargo workspace and .cargo/config.toml hierarchy correctly, not to force a full rebuild every time.
Can you explain what specific issue this is solving? There might be a better approach.
} | ||
|
||
// Force this task to always run by making outputs depend on buildRust | ||
outputs.upToDateWhen { false } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outputs.upToDateWhen { false }
forces this task to always run, even when nothing has changed. Combined with the cargo clean
, this means every build does a full Rust recompilation from scratch.
This will significantly impact developer productivity. Gradle's up-to-date checking should work correctly if the task inputs/outputs are properly declared. What specific issue are you trying to work around?
Issue link
This Pull Request is linked to issue (URL): [REPLACE ME]
Checklist
Before submitting the PR make sure the following are checked: