Skip to content

Conversation

liorsve
Copy link
Contributor

@liorsve liorsve commented Oct 6, 2025

This PR:

  1. adds the sync client docs to the website
  2. adds lua scripting guides (both for sync and async) to the docs- they were added as docs but not deployd, I added the sync version (same doc without async, await, fixed imports etc.)
  3. fixes the mkdocs-deploy workflow permissions.

See result deployed already to my github pages - https://liorsve.github.io/valkey-glide/

Issue link

This Pull Request is linked to issue: #3285

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated.
  • CHANGELOG.md and documentation files are updated.
  • Destination branch is correct - main or release
  • Create merge commit if merging release branch into main, squash otherwise.

Signed-off-by: Lior Sventitzky <[email protected]>
@liorsve liorsve requested a review from a team as a code owner October 6, 2025 11:59

permissions:
contents: read
contents: write
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

@liorsve liorsve Oct 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise the workflow fails, because we try to push to a branch. This permissions section was added after after we deployed the website, and we never deployed after it was added. Was supposed to be added with write permissions from the beginning.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it

Copy link
Collaborator

@shohamazon shohamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants