Stabilize combined publish/subscribe test by using unique channel names #4886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jessica Hsiao <[email protected]>
jh1231223
force-pushed
the
fix-test_pubsub_combined_exact_pattern_and_sharded_one_client
branch
from
4fb13a6 to
b14f737
Compare
|
Additional ask in ticket: #4862 (comment) |
jh1231223
added a commit
to jh1231223/valkey-glide
that referenced
this pull request
Oct 27, 2025
…attern_and_sharded_one_client' into fix-pubsub-deterministic-channels Merge valkey-io#4886 into valkey-io#4880 to combine flaky Pub/Sub test fixes Includes fixes from fix-test_pubsub_combined_exact_pattern_and_sharded_one_client into fix-pubsub-deterministic-channels as requested in issue valkey-io#4862. Stabilizes all related Pub/Sub tests with unique channel names and proper sync.#
|
Merged into #4880 as requested by the maintainer in this comment. |
jh1231223
deleted the
fix-test_pubsub_combined_exact_pattern_and_sharded_one_client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4862
Summary
I addressed flakiness in TestPubSub::
test_pubsub_combined_exact_pattern_and_sharded_one_client. The test occasionally reported an off-by-one result (e.g., 767/768). The root cause was key collisions across the randomly generated channel names for Exact, Pattern, and Sharded modes. When collisions occurred, dictionary entries were overwritten, reducing the number of distinct publishes and leading to a mismatched final count.What changed
Exact: "{channel}:{rand}:{i}"
Pattern: "{pattern}:{rand}:{i}"
Sharded: "{same-shard}:{i}:{rand}" (no space after the colon)
This preserves shard grouping via
{same-shard}and eliminates accidental overwrites without relaxing any assertions. The expected message count remainsNUM_CHANNELS * 3.Validation