Simplify offline build #73
Conversation
- add VALKEY_INCLUDE_DIR to avoid valkey download - add RAPIDJSON_SOURCE_DIR to avoid RapidJSON download
|
For your information, I'm working on RPM packaging of valkey, and its modules My work is available in my private repository, and may be integrated in Fedora official repository later See https://blog.remirepo.net/post/2025/08/01/Valkey-version-8.1 |
|
|
||
| if(ENABLE_UNIT_TESTS OR ENABLE_INTEGRATION_TESTS) | ||
| add_dependencies(${OBJECT_TARGET} valkey) | ||
| endif() |
There was a problem hiding this comment.
Is this dependency really needed ?
It blocks offline build (without valley tree)
build with BUILD_RELEASE, without ENABLE_UNIT_TESTS and without ENABLE_INTEGRATION_TESTS works
So I make it conditional
There was a problem hiding this comment.
the BUILD_RELEASE would require ./include/valkeymodule.h and thats why we would need the valkey
But I think would be resolved if we provide the path-to-valkey
We would also need to make changes to the CI to include VALKEY_INCLUDE_DIR
|
I think this would also resolve: #10 Can you also please sign-off the commits? |
|
We would also need to checkout valkey and add the path to the tests in order to run them as an offline build. |
2 participants
For distribution package (ex: RPM) the build is expected to be run offline.
add RAPIDJSON_SOURCE_DIR to avoid RapidJSON download
add VALKEY_INCLUDE_DIR to avoid valkey download
ex:
-DVALKEY_INCLUDE_DIR=/usr/includeas thevalkey-develpackage provides this header.