Skip to content

Conversation

cxljs
Copy link
Member

@cxljs cxljs commented Aug 23, 2025

refs: #75

@roshkhatri
Copy link
Member

roshkhatri commented Aug 25, 2025

Hey, Thank you for working on this, Can you also add a workflow for this check on very push and pull req?
Similar implementation can be found here in valkey: https://github.com/valkey-io/valkey/blob/unstable/.github/workflows/clang-format.yml:

Do we also want to use this: https://github.com/valkey-io/valkey-json/blob/unstable/src/json/CPPLINT.cfg?

@cxljs
Copy link
Member Author

cxljs commented Aug 26, 2025

Can you also add a workflow for this check on very push and pull req?

Yes, I will finish it later.

Do we also want to use this: https://github.com/valkey-io/valkey-json/blob/unstable/src/json/CPPLINT.cfg?

I was concerned that you might need the cpplint.cfg file, so I kept it. If you don't need it, I'll remove it later.

cxljs added 2 commits August 26, 2025 21:26
Signed-off-by: Xiaolong Chen <[email protected]>
Signed-off-by: Xiaolong Chen <[email protected]>
@roshkhatri
Copy link
Member

Okay will wait and review again when wfs are added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants