Custom responses and Standard Error types for cluster commands

[nilanshu-sharma]

Change Summary:

1. Adding custom responses for the following commands:

   • CLUSTER SLOTS
   • CLUSTER SLOT-STATS
   • CLUSTER LINKS

2. Converting error types for all Cluster Commands to RESPDecodeError

3. Removing docker network to make cluster-mode valkey directly accessible to integration tests while testing locally on laptop.

4. Restoring platform availability macros causing builds to fail

5. Also realized that the Integration tests meant to cluster-mode features are not running in the CI, so CI needs to be enhanced to run cluster mode related docker dependencies. For now the verification of new integration tests is done locally.

[github-actions]

✅ Pull request no significant performance differences ✅

Summary

New baseline 'pull_request' is WITHIN the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host '8ff82e9517c2' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

ValkeyBenchmarks

Client: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	75	76	78	80	80	80	80	7
pull_request	78	78	78	81	81	81	81	7
Δ	3	2	0	1	1	1	1	0
Improvement %	-4	-3	0	-1	-1	-1	-1	0

Client: GET benchmark | parallel 20 | 20 concurrent connections metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	71	78	79	82	83	84	84	30
pull_request	70	77	79	82	85	87	87	26
Δ	-1	-1	0	0	2	3	3	-4
Improvement %	1	1	0	0	-2	-4	-4	-4

Connection: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	4	4	4	4	4	15	15	10
pull_request	4	4	4	4	4	15	15	10
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

Connection: GET benchmark – NoOpTracer metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	7	8	8	10	11	11	11	9
pull_request	7	8	8	10	11	11	11	10
Δ	0	0	0	0	0	0	0	1
Improvement %	0	0	0	0	0	0	0	1

Connection: Pipeline array benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	33	33	34	34	34	34	34	7
pull_request	33	33	34	34	34	34	34	6
Δ	0	0	0	0	0	0	0	-1
Improvement %	0	0	0	0	0	0	0	-1

Connection: Pipeline benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	33	33	33	34	34	34	34	6
pull_request	33	33	33	34	34	34	34	7
Δ	0	0	0	0	0	0	0	1
Improvement %	0	0	0	0	0	0	0	1

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	21
pull_request	0	0	0	0	0	0	0	20
Δ	0	0	0	0	0	0	0	-1
Improvement %	0	0	0	0	0	0	0	-1

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	906
pull_request	0	0	0	0	0	0	0	893
Δ	0	0	0	0	0	0	0	-13
Improvement %	0	0	0	0	0	0	0	-13

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	2403
pull_request	0	0	0	0	0	0	0	2396
Δ	0	0	0	0	0	0	0	-7
Improvement %	0	0	0	0	0	0	0	-7

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) *	p0	p25	p50	p75	p90	p99	p100	Samples
main	0	0	0	0	0	0	0	447
pull_request	0	0	0	0	0	0	0	447
Δ	0	0	0	0	0	0	0	0
Improvement %	0	0	0	0	0	0	0	0

[adam-fowler]

Hi @nilanshu-sharma I've had a quick look at this on my phone. Hard to do a proper review on the phone, but see my comments related to errors thrown.

[adam-fowler]

A quick review from my iPhone

[nilanshu-sharma]

Thanks @adam-fowler. I have addressed your comments.