Weekly Test Runs on Released Branches #2702
Conversation
sarthakaggarwal97
force-pushed
the
weekly-release-daily-tests
branch
from
0de885f to
4622032
Compare
| const branches = await github.paginate(github.rest.repos.listBranches, { | ||
| owner, | ||
| repo, | ||
| per_page: 100, | ||
| }); |
There was a problem hiding this comment.
Why dont we use this kind of filter for branches:
branches:
- "[0-9].[0-9]"
Then we can filter which versions we want to run on
There was a problem hiding this comment.
This will support single digit branch numbers right like till 9.1. But as soon as we go 10 (multi digit version), it might break. I am not sure if github workflows supports regex.
.github/workflows/weekly.yml
Outdated
| core.info(`Found release branches: ${releaseBranches.join(', ')}`); | ||
| core.info(`Dispatching '${workflowId}' from ref '${workflowRef}'...`); |
There was a problem hiding this comment.
We can use the dispatch actions of workflows rather than the APIs, WDYT?
There was a problem hiding this comment.
We can refer to dail.yml to see how we can dispatch workflows
There was a problem hiding this comment.
uses: ./.github/workflows/update-valkey-hashes.yml
with:
version: ${{ needs.process-inputs.outputs.version }}
There was a problem hiding this comment.
Could you run it in your fork and share the run link here? Would like to visualize it.
@roshkhatri mentioned the daily runs on active PR against release branch. Do they conflict with each other or they just run in queued manner.
Signed-off-by: Sarthak Aggarwal <[email protected]>
sarthakaggarwal97
force-pushed
the
weekly-release-daily-tests
branch
from
4622032 to
8691d22
Compare
Signed-off-by: Sarthak Aggarwal <[email protected]>
sarthakaggarwal97
force-pushed
the
weekly-release-daily-tests
branch
from
8691d22 to
03c3d04
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #2702 +/- ##
============================================
- Coverage 72.57% 72.56% -0.01%
============================================
Files 128 128
Lines 71273 71278 +5
============================================
+ Hits 51724 51725 +1
- Misses 19549 19553 +4 🚀 New features to boost your workflow:
|
Signed-off-by: Sarthak Aggarwal <[email protected]>
3 participants
Resolves: #2228
Currently, there are no tests running on the already released branches. We often do backport for bug fixes and CVEs in these older versions, and end up with multiple CI tests failures on these branches.
The PR adds support for running weekly tests on already released versions
>= 7.2. The workflow will execute the "daily" test workflow for each of these branches onSunday 06:00 UTC.The idea is to continuously monitor our released versions through weekly test runs (during the time when is lesser activity on github runners).