Skip to content

Deflakes Primary COB growth with inactive replica #2715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2025
+8 −5
Merged

Deflakes Primary COB growth with inactive replica #2715

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions tests/integration/dual-channel-replication.tcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,10 +537,12 @@ start_server {tags {"dual-channel-replication external:skip"}} {
$primary config set repl-timeout 100
$replica config set repl-timeout 100
} else {
$primary config set repl-timeout 10
$replica config set repl-timeout 10
$primary config set repl-timeout 30
$replica config set repl-timeout 30
}
$primary config set rdb-key-save-delay 200

# Avoids timeout by keeping the RDB child alive longer while the replica is inactive
$primary config set rdb-key-save-delay 1000
populate 10000 primary 10000

set load_handle1 [start_one_key_write_load $primary_host $primary_port 100 "mykey1"]
Expand All @@ -556,10 +558,11 @@ start_server {tags {"dual-channel-replication external:skip"}} {
test "dual-channel-replication: Primary COB growth with inactive replica" {
$replica replicaof $primary_host $primary_port
# Verify repl backlog can grow
wait_for_condition 1000 10 {
wait_for_condition 2000 10 {
[s 0 mem_total_replication_buffers] > [expr {2 * $backlog_size}]
} else {
fail "Primary should allow backlog to grow beyond its limits during dual-channel-replication sync handshake"
set cur [s 0 mem_total_replication_buffers]
fail "Primary should allow backlog (have=$cur, need>[expr {2 * $backlog_size}]) to grow beyond its limits during dual-channel-replication sync handshake"
}
wait_and_resume_process -1

Expand Down
Loading