Skip to content

Conversation

jdheyburn
Copy link

  • Dual channel replication does not use replica-announce-ip
  • This causes stale replicas in Sentinel
  • This change fixes that to use replica-announce-ip if it is set

- Dual channel replication does not use replica-announce-ip
- This causes stale replicas in Sentinel
- This change fixes that to use replica-announce-ip if it is set

Signed-off-by: Joseph Heyburn <[email protected]>
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.58%. Comparing base (28e5dcc) to head (28825cc).
⚠️ Report is 2 commits behind head on unstable.

Files with missing lines Patch % Lines
src/replication.c 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2733      +/-   ##
============================================
- Coverage     72.61%   72.58%   -0.03%     
============================================
  Files           128      128              
  Lines         71278    71283       +5     
============================================
- Hits          51755    51742      -13     
- Misses        19523    19541      +18     
Files with missing lines Coverage Δ
src/replication.c 85.98% <20.00%> (-0.13%) ⬇️

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant