Skip to content

Conversation

zuiderkwast
Copy link
Contributor

#2329 intoduced a bug that causes a blocked client in cluster mode to receive two MOVED redirects instead of one. This was not seen in tests, except in the reply schema validator.

The fix makes sure the client's pending command is cleared after sending the MOVED redirect, to prevent if from being reprocessed.

Fixes #2676.

@zuiderkwast zuiderkwast added the run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP) label Oct 14, 2025
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.60%. Comparing base (ccf6fca) to head (0f55d10).
⚠️ Report is 1 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #2734      +/-   ##
============================================
- Coverage     72.60%   72.60%   -0.01%     
============================================
  Files           128      128              
  Lines         71278    71278              
============================================
- Hits          51754    51750       -4     
- Misses        19524    19528       +4     
Files with missing lines Coverage Δ
src/blocked.c 91.32% <100.00%> (ø)

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hpatro hpatro moved this to To be backported in Valkey 9.0 Oct 14, 2025
@zuiderkwast zuiderkwast merged commit 54da834 into valkey-io:unstable Oct 14, 2025
63 of 64 checks passed
@hpatro
Copy link
Collaborator

hpatro commented Oct 14, 2025

I believe this needs to be backported by 9.0 GA.

@zuiderkwast zuiderkwast deleted the fix-double-moved-on-unblock branch October 14, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-extra-tests Run extra tests on this PR (Runs all tests from daily except valgrind and RESP)

Projects

Status: To be backported

Development

Successfully merging this pull request may close these issues.

[TEST-FAILURE] reply-schemas-validator failing in daily test

3 participants