Skip to content

Conversation

@Goooler
Copy link
Contributor

@Goooler Goooler commented Oct 24, 2025

Consider bumping the min Gradle requirement to 9.0.0 in a new PR.


  • CHANGELOG's "Unreleased" section has been updated, if applicable.

@Goooler
Copy link
Contributor Author

Goooler commented Oct 24, 2025

@gabrielittner
Copy link
Collaborator

I'm planning to bump the min Java version after the next release, so we can merge this then, but could you undo the change to just on the latest Java version? Since the tests run on multiple Gradle versions, AGP versions, Kotlin versions etc the older ones often don't support the latest JDK and are skipped there. So running on min + latest will cover everything.

Copy link
Collaborator

@gabrielittner gabrielittner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for rebasing, will merge this after the next release

@Goooler Goooler closed this Nov 11, 2025
@Goooler Goooler reopened this Nov 11, 2025
@gabrielittner gabrielittner merged commit b6c6ada into vanniktech:main Nov 11, 2025
10 of 14 checks passed
@Goooler Goooler deleted the min-java-17 branch November 11, 2025 16:58
@Goooler
Copy link
Contributor Author

Goooler commented Nov 11, 2025

We can rebase #1037 for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants