Hook based component refactor and dependency update #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I tried to install this package but ran into a peer dependency issue whereas npm was complaining about my installed react-native-svg being quite a few major versions ahead of the required by this package. (5 <> 12)
So I first wanted to find out if it would break with the newest version. -> it did not.
Then react native threw a warning about the - since renamed - componentWillReceiveProps function that led me to refactor the main component to use hooks instead of being class based. Obviously tested it thoroughly.
Please note that this is my first ever open source contribution, so if you don't like something, pls be gentle :)