Added support for JSON number values#3
Open
situokko wants to merge 3 commits into
Open
Conversation
Imran-imtiaz48
left a comment
Imran-imtiaz48
left a comment
There was a problem hiding this comment.
Generates a JSON-style key-value pair from XML nodes, intelligently wrapping non-numeric values in quotes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for JSON number values, such as iat, when converting XML->JSON.
Known issues: As IsNumeric() seems to validate numbers inside a string very liberally so that floats '123.567' and formatted decimals '123.9,00' are detected as numbers, while they are not valid in JSON. Could be fixed by switching the test function to something more strict?