Support selecting attesters in /ratsd/chares#69
Merged
Merged
Conversation
Place string tsm-report between a pair of quotes to the example of Complex queries README.md, and move tsm-repot under attester-selection Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
Make `attester-selection` a list of attester names instead of an object containing nested option maps. Read attester-specific options from top-level JSON fields named after each attester, and allow attesters with no options to be selected without requiring `"attester-id": null`. Update the `/ratsd/chares` handler, tests, OpenAPI schema/generated types, and README examples to match the new request format. Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
Apply request-provided attester selection even when the server is not running in selected mode, and add coverage for the all-mode request path. Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
cowbon
requested review from
deeglaze,
iolivergithub,
jraman567 and
thomas-fossati
as code owners
Return a specific error when the request body cannot be deserialized as JSON while preserving the existing missing-nonce validation path. Add coverage for malformed JSON and missing nonce requests in the POST /ratsd/chares tests. Signed-off-by: Ian Chin Wang <ian.chin.wang@oracle.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attester-selectionas a list of attester names and read attester-specific options from top-level request fields/ratsd/charesresponses while still enforcing selection inselectedmodeTesting
go test ./api/...