Skip to content

[codex] Fix native test determinism#1342

Open
Stanzilla wants to merge 1 commit into
vercel-labs:mainfrom
Stanzilla:codex/fix-test-determinism
Open

[codex] Fix native test determinism#1342
Stanzilla wants to merge 1 commit into
vercel-labs:mainfrom
Stanzilla:codex/fix-test-determinism

Conversation

@Stanzilla
Copy link
Copy Markdown

Summary

  • shorten dispatch-only parity commands that were spending real default timeouts in browser wait handlers
  • avoid navigating through auth_login in the parity coverage test by using a missing profile
  • close the browser at the end of the parity coverage test
  • guard AGENT_BROWSER_DEFAULT_TIMEOUT env mutation in timeout tests with EnvGuard

Root Cause

test_all_documented_actions_are_handled is a dispatch coverage test, but several minimal commands were exercising real wait paths with the default timeout. That made cargo test look hung and left Chrome alive while the test slowly timed out. Separately, default timeout tests mutated AGENT_BROWSER_DEFAULT_TIMEOUT without the shared env guard, so parallel test execution could leak the value between tests.

Validation

  • cargo fmt -- --check
  • git diff --check
  • cargo test native::parity_tests::test_all_documented_actions_are_handled
  • cargo test native::actions::tests::test_default_timeout_ms
  • cargo test

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 9, 2026

@Stanzilla is attempting to deploy a commit to the Vercel Labs Team on Vercel.

A member of the Team first needs to authorize it.

@Stanzilla Stanzilla marked this pull request as ready for review May 9, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant