[codex] Fix native test determinism#1342
Open
Stanzilla wants to merge 1 commit into
Open
Conversation
Contributor
|
@Stanzilla is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auth_loginin the parity coverage test by using a missing profileAGENT_BROWSER_DEFAULT_TIMEOUTenv mutation in timeout tests withEnvGuardRoot Cause
test_all_documented_actions_are_handledis a dispatch coverage test, but several minimal commands were exercising real wait paths with the default timeout. That madecargo testlook hung and left Chrome alive while the test slowly timed out. Separately, default timeout tests mutatedAGENT_BROWSER_DEFAULT_TIMEOUTwithout the shared env guard, so parallel test execution could leak the value between tests.Validation
cargo fmt -- --checkgit diff --checkcargo test native::parity_tests::test_all_documented_actions_are_handledcargo test native::actions::tests::test_default_timeout_mscargo test