fix: harden dashboard and inspect local control planes#1346
Conversation
|
@Muhtasham is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
e461dbf to
f84bd5e
Compare
Thanks for flagging this. I independently reached the same conclusion during a follow-up security pass: the dashboard WebSocket proxy was still using an older Host/Origin authority match that did not include the DNS-rebinding hardening added for the HTTP routes. I pushed
Validation run locally:
That focused stream suite passes with the new regression coverage. |
|
Follow-up:
The new patch tokenizes the generated inspect DevTools Validation run:
|
Summary
/api/commandrelay issue from Per-session /api/command should require same-origin or token auth #1344/api/exec,/api/sessions,/api/kill)OriginorRefererbefore/api/sessionscan spawn browser sessionsOriginfor dashboard WebSocket proxy routes when a browser Origin is present/api/sessionsrejection, and inspect-mode token/origin checksFixes #1345.
Fixes #1347.
Validation
cargo fmt --manifest-path cli/Cargo.toml -- --checkcargo test --manifest-path cli/Cargo.toml native::stream::http::tests -- --test-threads=1 --nocapturecargo test --manifest-path cli/Cargo.toml native::stream:: -- --test-threads=1 --nocapturecargo test --manifest-path cli/Cargo.toml native::inspect_server::tests -- --nocapturecargo clippy --manifest-path cli/Cargo.toml -- -D warnings/api/execnow return 403 without CORS; same-origin POST still returns 200.