fix: accept slash-qualified model IDs#1
Open
EfeDurmaz16 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_model_by_id()to resolve bothprovider:modelandprovider/modelIDsWhy
The README demonstrates
get_model_by_id("openai/gpt-5.5"), but the implementation only accepted colon-qualified IDs.parse_model_id()already recognizes slash-qualified provider IDs, so this aligns lookup behavior with the documented API shape.Verification
uv run pytestDuplicate check
vercel-labs/modelsdotdev-python; there were no existing issues or PRs for this mismatch.