Skip to content

fix(add): discover explicitly named nested skills#1158

Open
EfeDurmaz16 wants to merge 1 commit into
vercel-labs:mainfrom
EfeDurmaz16:efe/full-depth-skill-filter
Open

fix(add): discover explicitly named nested skills#1158
EfeDurmaz16 wants to merge 1 commit into
vercel-labs:mainfrom
EfeDurmaz16:efe/full-depth-skill-filter

Conversation

@EfeDurmaz16
Copy link
Copy Markdown

Summary

  • search full depth when skills add has an explicit --skill filter
  • skip the GitHub blob fast path for those named installs so nested skills are available from the cloned tree
  • add a regression test for an AWS-style deeply nested aws-transform skill alongside a shallow skill

Fixes #1148.

Verification

  • pnpm install
  • pnpm format
  • pnpm format:check
  • pnpm exec vitest run src/add.test.ts -t "should discover deeper nested skills" --testTimeout=15000
  • pnpm exec vitest run src/add.test.ts --testTimeout=15000
  • pnpm build

Blocked / known failing checks

  • pnpm type-check currently fails on unrelated upstream type errors in src/git.ts and src/skills.ts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot install skill using the npx skills add command

1 participant