fix: add optional chaining for finishReason to prevent crashes with gateway#13665
Open
guoyangzhen wants to merge 1 commit intovercel:mainfrom
Open
fix: add optional chaining for finishReason to prevent crashes with gateway#13665guoyangzhen wants to merge 1 commit intovercel:mainfrom
guoyangzhen wants to merge 1 commit intovercel:mainfrom
Conversation
tigent
bot
added
ai/core
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| OnToolCallFinishEvent, | ||
| OnToolCallStartEvent, | ||
| } from './callback-events'; | ||
| } from './core-events'; |
Contributor
There was a problem hiding this comment.
Multiple TypeScript compilation errors in generate-text.ts: wrong import path, non-existent generic parameters, and reference to non-existent property.
| : InferSchema<SCHEMA>, | ||
| >( | ||
| options: Omit<CallSettings, 'stopSequences'> & | ||
| options: Omit<CallSettings<any>, 'stopSequences'> & |
Contributor
There was a problem hiding this comment.
CallSettings and TimeoutConfiguration are used as generic types (CallSettings<any>, CallSettings<TOOLS>, TimeoutConfiguration<TOOLS>) but they are not generic, causing TypeScript compilation errors (TS2315).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using generateText() or generateObject() with Google image generation models through the Vercel AI Gateway, the SDK crashes with:
The gateway may return responses without finishReason for certain model types (e.g. image generation). The SDK accesses result.finishReason.unified without null-checking.
Fix
Add optional chaining (.?.unified) at all 8 locations where finishReason.unified or finishReason.raw is accessed in the core generate-text and generate-object packages. This prevents the crash while preserving normal behavior when finishReason is present.
Files Changed