fix(provider-utils): retry on Node.js socket termination errors#13668
Open
sidx1024 wants to merge 1 commit intovercel:mainfrom
Open
fix(provider-utils): retry on Node.js socket termination errors#13668sidx1024 wants to merge 1 commit intovercel:mainfrom
sidx1024 wants to merge 1 commit intovercel:mainfrom
Conversation
TypeError: terminated and SocketError: other side closed are thrown by Node.js undici when the TCP socket dies mid-response. These are transient network errors but handleFetchError only recognized "fetch failed" / "failed to fetch", so they were not wrapped as retryable APICallErrors. This adds detection for socket termination errors so they are properly retried by the exponential backoff logic. Fixes vercel#11265 Fixes vercel#9775
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeError: terminatedandSocketError: other side closedare thrown by Node.js undici when the TCP socket dies mid-response (e.g. during long-runninggenerateTextcalls with reasoning models). These are transient network errors, buthandleFetchErroronly recognizes"fetch failed"/"failed to fetch", so they fall through as raw errors and are not retried by the exponential backoff logic.This adds detection for socket termination errors (
terminated,other side closed,UND_ERR_SOCKETcode) so they are properly wrapped as retryableAPICallErrors.Reproduction
When using
generateTextwith models that have long response times (e.g.gpt-5.2withreasoningEffort: "high"), the TCP socket can be terminated by intermediate infrastructure. The error surfaces as:or:
Neither error is retried because
handleFetchErrorreturns them as-is.Changes
isSocketError()helper that matchesterminated,other side closedmessages andUND_ERR_SOCKETerror codeAPICallErrorwithisRetryable: trueTest plan
TypeError: terminated→ retryableAPICallErrorSocketError: other side closed(codeUND_ERR_SOCKET) → retryableAPICallErrorTypeError: terminatedas cause offetch failed→ retryable (existing path, confirmed)Fixes #11265
Fixes #9775