fix(github): correctly trigger removeReaction in multi-tenant mode#250
Merged
fix(github): correctly trigger removeReaction in multi-tenant mode#250
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
matchai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In multi-tenant mode (GitHub App without a fixed
installationId),initialize()skips_botUserIdauto-detection because there's no global octokit client. This leaves_botUserIdasnull, soremoveReactionnever finds a matching reaction to delete — thereactions.find()filter always fails.Fixes this by lazily detecting
_botUserIdviausers.getAuthenticated()on the per-installation octokit client thatremoveReactionalready has available. The result is cached, so subsequent calls skip the extra API call.