fix: SDK key detection to avoid false positives with third-party identifier#345
Merged
fix: SDK key detection to avoid false positives with third-party identifier#345
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
swarnava
force-pushed
the
fix/sdk-key-detection-regex
branch
from
a6b876b to
4a73fb7
Compare
Contributor
|
You must have Developer access to commit code to Uncurated Tests - Temporary on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
dferber90
approved these changes
Mar 21, 2026
swarnava
force-pushed
the
fix/sdk-key-detection-regex
branch
from
4a73fb7 to
26594aa
Compare
…tifiers The SDK key validation now uses a regex (/^vf_(?:server|client)_/) to require the format vf_server_* or vf_client_* instead of accepting any string starting with vf_. This prevents false positives with third-party service identifiers that happen to start with vf_ (e.g., Stripe identity flow IDs like vf_1PyHgVLpWuMxVFx...). Adds isValidSdkKey() helper function and updates parseSdkKeyFromFlagsConnectionString() to use the stricter validation. Updates all tests to use valid SDK key formats.
swarnava
force-pushed
the
fix/sdk-key-detection-regex
branch
from
26594aa to
618698f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK key validation now uses a regex
/^vf_(?:server|client)_/to require the formatvf_server_*orvf_client_*instead of accepting any string starting withvf_. This prevents false positives with third-party service identifiers that happen to start with vf_ (e.g., Stripe identity flow IDs likevf_1PyHgVLpWuMxVFx...).Adds
isValidSdkKey()helper function and updatesparseSdkKeyFromFlagsConnectionString()to use the stricter validation. Updates all tests to use valid SDK key formats.