fix(eslint-plugin-next): support custom pageExtensions in no-html-lin… #85967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k-for-pages rule This fixes issue vercel#53473 by updating the rule to properly recognize pages with custom configured in or ESLint settings. Changes: - Added utility to read from config - Updated and to use dynamic extensions - Modified rule to pass to URL parsing functions - Added tests for custom from both and ESLint settings The rule now correctly identifies internal links to pages with custom extensions (e.g., .mdx) and flags them appropriately.
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| } | ||
| } else { | ||
| const dirPath = path.join(directory, dirent.name) | ||
| if (dirent.isDirectory(dirPath) && !dirent.isSymbolicLink()) { |
Contributor
There was a problem hiding this comment.
The isDirectory() method on the dirent object doesn't accept any parameters. It should be called without arguments:
if (dirent.isDirectory() && !dirent.isSymbolicLink()) {This appears to be a bug that could cause incorrect directory detection, as the current code is passing dirPath as an argument to a method that doesn't expect one.
Suggested change
| if (dirent.isDirectory(dirPath) && !dirent.isSymbolicLink()) { | |
| if (dirent.isDirectory() && !dirent.isSymbolicLink()) { |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53473
Summary
@next/next/no-html-link-for-pagesto read page extensions fromnext.config.jsor ESLint settingspageExtensionsscenariosTesting