-
Notifications
You must be signed in to change notification settings - Fork 29.9k
[turbopack] Enable turbopackFileSystemCacheForDev by default and release turbopackFileSystemCacheForBuild to stable builds #85975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lukesandberg
wants to merge
2
commits into
graphite-base/85975
Choose a base branch
from
flip_flip_flip
base: graphite-base/85975
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6
−16
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of the canary-only check for
turbopackFileSystemCacheForBuildwill cause the existing test inconfig.test.ts(line 99-111) to fail, as the test expects this validation error to be thrown but the code no longer throws it.View Details
📝 Patch Details
Analysis
Test failure: outdated canary-only validation check for turbopackFileSystemCacheForBuild
What fails: Test
errors when using persistentCachingForBuild if not in canaryinpackages/next/src/server/config.test.ts(lines 99-111) expects a validation error to be thrown whenexperimental.turbopackFileSystemCacheForBuildis used in non-canary builds, but the validation code was removed.How to reproduce:
pnpm testonly -- packages/next/src/server/config.test.ts --testNamePattern="errors when using persistentCachingForBuild if not in canary"Result: Test fails with error:
Expected: toThrowbut no error was thrown. The config loads successfully withturbopackFileSystemCacheForBuild: truein stable builds.Expected behavior: Since commit
51fd761f4b("Release turbopackFileSystemCacheForBuild to stable builds") intentionally removed the canary-only restriction fromconfig.ts(lines 398-408 in the original code), the test should be removed or updated to verify the feature now works in stable builds.Fix: Removed the outdated test as the feature is now available in stable builds. The test was checking for a validation that no longer exists by design. All remaining tests pass (1804 tests in total).