-
Notifications
You must be signed in to change notification settings - Fork 29.8k
perf: revert to use the light safe stringify for is-error #86053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Failing test suitesCommit: 43de3e8 | About building and testing Next.js
Expand output● next-server-nft › should not trace too many files in next-server.js.nft.json ● next-server-nft › should not trace too many files in next-minimal-server.js.nft.json
Expand output● app dir - prefetching › should show layout eagerly when prefetched with loading one level down |
`is-error` is a helper that being used accorss client and server now, in #84909 we switched the underlying safe stringify error implementation to the precompiled dependency `safe-stable-stringify`. But it increased the client bundle size a bit. The change in #84909 was only for applying the `safe-stable-stringify` for client file logger with mcp, not really necessary need to change for is-error helper Note: Save minified around 12kb. it's actually 7.5kb on bundlephobia, but because we're using ncc to compile it to cjs dependency that the size seems slightly larger than their metrics. The saved gzip size would be around 2-3.x kb
is-erroris a helper that being used accorss client and server now, in #84909 we switched the underlying safe stringify error implementation to the precompiled dependencysafe-stable-stringify. But it increased the client bundle size a bit.The change in #84909 was only for applying the
safe-stable-stringifyfor client file logger with mcp, not really necessary need to change for is-error helperNote: Save minified around 12kb. it's actually 7.5kb on bundlephobia, but because we're using ncc to compile it to cjs dependency that the size seems slightly larger than their metrics. The saved gzip size would be around 2-3.x kb