Skip to content

test: explain tooling deployment exclusions - #98478

Draft
jamiboym wants to merge 1 commit into
jamiboym/deploy-exclusion-reasons/app-routerfrom
jamiboym/deploy-exclusion-reasons/tooling
Draft

test: explain tooling deployment exclusions#98478
jamiboym wants to merge 1 commit into
jamiboym/deploy-exclusion-reasons/app-routerfrom
jamiboym/deploy-exclusion-reasons/tooling

Conversation

@jamiboym

Copy link
Copy Markdown

Summary

Replace 23 deployment-exclusion TODO comments with concrete reasons across 21 tooling test files. Retain every force-gate and leave test assertions unchanged.

Reasons describe local file/build access, server lifecycle or runtime-log requirements, and intentionally failing builds, based on source inspection and deployment CI failures.

Verification

  • 78 gate infrastructure unit tests passed.
  • Gate transforms and executable AST equivalence checked for every edited file.
  • Full worktree bootstrap blocked by missing package-level ncc/microbundle dependencies.

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Failing test suites

Commit: 5a27932 | About building and testing Next.js

pnpm test-dev test/development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts (job)

  • instant-nav-panel > history traversals > re-arms the capture when navigating back from a captured SPA navigation (DD)
Expand output

● instant-nav-panel › history traversals › re-arms the capture when navigating back from a captured SPA navigation

locator.waitFor: Timeout 60000ms exceeded.
Call log:
  - waiting for locator('[data-testid="dynamic-skeleton"]') to be visible

  278 |     await browser
  279 |       .locator('[data-testid="dynamic-skeleton"]')
> 280 |       .waitFor({ state: 'visible' })
      |        ^
  281 |     await browser
  282 |       .locator('[data-testid="param-skeleton"]')
  283 |       .waitFor({ state: 'visible' })

  at waitFor (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:280:8)
  at Object.expectTargetPageSpaShell (development/app-dir/instant-navs-devtools/instant-navs-devtools.test.ts:834:13)

@jamiboym
jamiboym added this pull request to stack #98482 September 10, 2026 03:27
@jamiboym
jamiboym force-pushed the jamiboym/deploy-exclusion-reasons/tooling branch from edf27ec to 5a27932 Compare September 10, 2026 13:36
@jamiboym
jamiboym force-pushed the jamiboym/deploy-exclusion-reasons/tooling branch from 5a27932 to 44f43e9 Compare September 10, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant