Skip to content
This repository was archived by the owner on Jan 21, 2023. It is now read-only.

Testing resvg-js#183

Closed
styfle wants to merge 13 commits intomainfrom
resvg-js
Closed

Testing resvg-js#183
styfle wants to merge 13 commits intomainfrom
resvg-js

Conversation

@styfle
Copy link
Copy Markdown
Member

@styfle styfle commented Jan 7, 2022

Fails without valid svg so I had to add version and xmlns

<svg version="1.0" xmlns="http://www.w3.org/2000/svg" width="1280" height="640">

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vercel/og-image/8HNrSByPrRAiyjPAgQ7GCXE8ojFi
✅ Preview: https://og-image-git-resvg-js.vercel.sh

@styfle styfle changed the title Testing resvg-js Testing resvg-js Jan 11, 2022
@styfle styfle mentioned this pull request Jan 11, 2022
@yisibl
Copy link
Copy Markdown

yisibl commented Jan 20, 2022

Fails without valid svg so I had to add version and xmlns

Yes, resvg must parse the spec compliant SVG format. If there are special requirements, they can be handled in the preprocess.

Thank you for using resvg-js and feel free to raise an issue if you need it.

@SpaceK33z
Copy link
Copy Markdown

resvg-js is really cool but it seems to still miss the feature to render images, which this project would need.

@yisibl
Copy link
Copy Markdown

yisibl commented Apr 14, 2022

resvg-js is really cool but it seems to still miss the feature to render images, which this project would need.

@SpaceK33z Don't worry, we'll implement it in a subsequent release.

@styfle
Copy link
Copy Markdown
Member Author

styfle commented Jan 20, 2023

Closing in favor of #226

@styfle styfle closed this Jan 20, 2023
@styfle styfle deleted the resvg-js branch January 20, 2023 23:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants