-
Notifications
You must be signed in to change notification settings - Fork 197
feat: Conditionally handle incompletes #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
2hu12
wants to merge
1
commit into
vercel:main
Choose a base branch
from
2hu12:patch-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "streamdown": minor | ||
| --- | ||
|
|
||
| Add new option `extraIncompleteHandles` that allows users to configure how unterminated Markdown blocks are handled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Block component memo comparison only checks content but ignores extraIncompleteHandles, causing stale renders when extraIncompleteHandles changes.
View Details
📝 Patch Details
Analysis
Block component memo comparison ignores extraIncompleteHandles causing stale renders
What fails: The
Blockcomponent's React.memo comparison function only checkscontentprop, ignoringextraIncompleteHandlesandshouldParseIncompleteMarkdowndependencies used in the component's useMemo hook.How to reproduce:
<Streamdown extraIncompleteHandles={[handler1]}>content</Streamdown><Streamdown extraIncompleteHandles={[handler2]}>content</Streamdown>Result: Block component shows stale parsed content when
extraIncompleteHandleschanges, because memo comparison returnstrue(no re-render needed) even though the useMemo dependencies have changed.Expected: Component should re-render when any useMemo dependency changes, producing different parsed output when handlers change.
Root cause: Both
StreamdownandBlockmemo functions were incomplete:Blockmemo only checkedcontentbut ignoredextraIncompleteHandlesandshouldParseIncompleteMarkdownStreamdownmemo only checkedchildren,shikiTheme, andisAnimatingbut ignoredextraIncompleteHandles