Skip to content

Conversation

@TooTallNate
Copy link
Member

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 24, 2025

⚠️ No Changeset found

Latest commit: effaec6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Contributor

vercel bot commented Nov 24, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview Comment Nov 27, 2025 8:27pm
example-nextjs-workflow-webpack Ready Ready Preview Comment Nov 27, 2025 8:27pm
example-workflow Ready Ready Preview Comment Nov 27, 2025 8:27pm
workbench-astro-workflow Error Error Nov 27, 2025 8:27pm
workbench-express-workflow Ready Ready Preview Comment Nov 27, 2025 8:27pm
workbench-fastify-workflow Error Error Nov 27, 2025 8:27pm
workbench-hono-workflow Ready Ready Preview Comment Nov 27, 2025 8:27pm
workbench-nitro-workflow Ready Ready Preview Comment Nov 27, 2025 8:27pm
workbench-nuxt-workflow Ready Ready Preview Comment Nov 27, 2025 8:27pm
workbench-sveltekit-workflow Ready Ready Preview Comment Nov 27, 2025 8:27pm
workbench-vite-workflow Ready Ready Preview Comment Nov 27, 2025 8:27pm
workflow-docs Ready Ready Preview Comment Nov 27, 2025 8:27pm

@TooTallNate TooTallNate changed the title Test workflow-server 102 Test workflow-server 106 Nov 27, 2025
): { baseUrl: string; usingProxy: boolean } => {
const projectConfig = config?.projectConfig;
const defaultUrl = 'https://vercel-workflow.com/api';
const defaultUrl = 'https://workflow-server-chxm50ofc.vercel.sh/api';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const defaultUrl = 'https://workflow-server-chxm50ofc.vercel.sh/api';
const defaultUrl = 'https://vercel-workflow.com/api';

The default API URL for workflow API requests is hardcoded to a temporary Vercel deployment-specific URL that will break when the deployment is redeployed. Should use the stable production domain instead.

View Details

Analysis

Hardcoded Vercel deployment-specific URL breaks when deployment changes

What fails: The defaultUrl in packages/world-vercel/src/utils.ts (line 113) is hardcoded to a temporary Vercel deployment URL https://workflow-server-chxm50ofc.vercel.sh/api. This URL will become invalid when the deployment is redeployed, rebuilt, or deleted per Vercel's deployment URL retention policy.

How to reproduce: Any code that calls getHttpUrl(), getHttpConfig(), or makeRequest() without providing a custom baseUrl and without using proxy mode will use this temporary deployment-specific URL. When Vercel redeploys the workflow-server deployment (creating a new deployment ID), the hardcoded URL will point to an invalid/deleted deployment.

Result: API calls to the hardcoded URL fail once the deployment changes, breaking the default functionality for any users who rely on the default endpoint without custom configuration.

Expected: Should use the stable production domain https://vercel-workflow.com/api instead of a temporary deployment-specific URL. Git history shows this was the production URL in commit 2dca0d4 before being replaced by a test deployment URL in commit 743b780 ("Test workflow-server 102").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants