-
Notifications
You must be signed in to change notification settings - Fork 118
Test workflow-server 106 #408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| ): { baseUrl: string; usingProxy: boolean } => { | ||
| const projectConfig = config?.projectConfig; | ||
| const defaultUrl = 'https://vercel-workflow.com/api'; | ||
| const defaultUrl = 'https://workflow-server-chxm50ofc.vercel.sh/api'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| const defaultUrl = 'https://workflow-server-chxm50ofc.vercel.sh/api'; | |
| const defaultUrl = 'https://vercel-workflow.com/api'; |
The default API URL for workflow API requests is hardcoded to a temporary Vercel deployment-specific URL that will break when the deployment is redeployed. Should use the stable production domain instead.
View Details
Analysis
Hardcoded Vercel deployment-specific URL breaks when deployment changes
What fails: The defaultUrl in packages/world-vercel/src/utils.ts (line 113) is hardcoded to a temporary Vercel deployment URL https://workflow-server-chxm50ofc.vercel.sh/api. This URL will become invalid when the deployment is redeployed, rebuilt, or deleted per Vercel's deployment URL retention policy.
How to reproduce: Any code that calls getHttpUrl(), getHttpConfig(), or makeRequest() without providing a custom baseUrl and without using proxy mode will use this temporary deployment-specific URL. When Vercel redeploys the workflow-server deployment (creating a new deployment ID), the hardcoded URL will point to an invalid/deleted deployment.
Result: API calls to the hardcoded URL fail once the deployment changes, breaking the default functionality for any users who rely on the default endpoint without custom configuration.
Expected: Should use the stable production domain https://vercel-workflow.com/api instead of a temporary deployment-specific URL. Git history shows this was the production URL in commit 2dca0d4 before being replaced by a test deployment URL in commit 743b780 ("Test workflow-server 102").
No description provided.