Fix command injection vulnerability in CI workflow via untrusted fork PR #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pranaygp
changed the title
…nt variables
Replace direct interpolation of ${{ matrix.app.name }} in shell commands with environment
variables passed via the env: section. All paths are now quoted to prevent command injection
from untrusted fork PRs.
Affected jobs:
- e2e-local-dev: Setup canary, Resolve symlinks, Run E2E Tests
- e2e-local-prod: Setup canary, Run E2E Tests
- e2e-local-postgres: Setup canary, Run E2E Tests
Co-authored-by: pranaygp <[email protected]>
Copilot
AI
changed the title
[WIP] Fix command injection in CI workflow
Fix command injection vulnerability in CI workflow via untrusted fork PR
Nov 26, 2025
Copilot finished work on behalf of
pranaygp
November 26, 2025 18:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct interpolation of
${{ matrix.app.name }}in shell commands allows command injection from fork PRs that modifyscripts/create-test-matrix.mjs.Changes
${{ matrix.app.name }}interpolation with environment variables in shell commandsBefore:
After:
Jobs fixed
e2e-local-dev: Setup canary, Resolve symlinks, Run E2E Testse2e-local-prod: Setup canary, Run E2E Testse2e-local-postgres: Setup canary, Run E2E TestsView original Slack conversation
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.