Skip to content

Feature/868 Mint sbts + Data connector refactor #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 20 commits into
base: develop
Choose a base branch
from
Draft

Feature/868 Mint sbts + Data connector refactor #1104

wants to merge 20 commits into from

Conversation

@tahpot
Copy link
Member

@tahpot tahpot commented Nov 14, 2023 •
edited
Loading

💭 What's changed?

🧪 How to test these changes?

  1. Verida Wallet release 0.6.1 must be completed as it removes the connections tab (@aurelticot)
  2. Data connector PR to be deployed to the data connector server (@tahpot)
  3. Data connector server; Remove Twitter (@tahpot)
  4. This PR to be fully tested end-to-end with Facebook and Discord (ensure all connectors authenticate and sync data as expected) (@aurelticot)
  5. Verida Missions be updated to have a mission that requests the user prove they are part of a Discord server (test on localhost) (@aurelticot)

🧪 Release plan

If all good:

  1. Update the data connector server to have more CPU and RAM (@nick-verida)
  2. Release the Verida Wallet (@aurelticot)
  3. Release the Verida Mission (@aurelticot)

😨 Anything to be aware of?

Chris and others added 13 commits April 5, 2023 21:38
Add basic SBT minting (untested)
a97ebbe
Add @verida/vda-sbt-client dependency
48602bd
Start of SBTManager
cbe021a
Remove unused vault manager files
aeb9b21
Pull connectors from the server. Trigger SBT credential saving if inc…
ded2a10 
…luded in the profile.
Basic SBT Manager working. Issues with SBT client library in the prot…
2b4eb7b 
…ocol though.
Add basic mint / burn buttons on credentials for testing.
01aaef7
Fix connection display with updated provider details
b3f9538
Inject connection info when loading from data connection deep link
80ecea1
Add isMinted with debug output
6374754
Load collectibles for polygon, not ethereum
b773068
Force .json extension on minted SBTs. Update isMinted() to refere…
30b77e2 
…nce the `did`
@tahpot
Feature: 868 Mint SBTs + Data connector refactor changes (#1103)
b5fb2d2
@tahpot tahpot added the enhancement New feature or request label Nov 14, 2023
@andy-verida
Merge remote-tracking branch 'origin/develop' into feature/868-mint-sbts
8d06e25 
# Conflicts:
#	package.json
#	src/api/VaultCommon/managers/credentials.ts
#	src/hooks/useDeeplink.ts
#	src/pages/Assets/Collectibles.tsx
#	src/pages/Connections/SingleConnection.js
#	src/pages/Data/CredentialDataItem.tsx
#	yarn.lock
@andy-verida
chore: enabled Connections tab
fc7711e
@aurelticot aurelticot assigned andy-verida and unassigned aurelticot Nov 27, 2023
@andy-verida
Copy link
Contributor

@tahpot @aurelticot This PR is now synced up with the development branch.

@tahpot as we updated a bit on how the .env works last month, so if you have any issues running the project, just let us know

Related doc: https://github.com/verida/vault-mobile#environment-variables

@aurelticot
Copy link
Member

@andy-verida the CI didn't pass

@tahpot
Copy link
Member Author

tahpot commented Dec 5, 2023

@andy-verida I have this roughly working, however I can't seem to fix this issue:

https://www.loom.com/share/b862a4de27fe41c992fb80f8dfde8658?from_recorder=1&focus_title=1

In order to replicate you need to update your DATA_CONNECTOR_URL=https://dataconnector-staging.tn.verida.tech in config.

@andy-verida
Copy link
Contributor

@andy-verida I have this roughly working, however I can't seem to fix this issue:

https://www.loom.com/share/b862a4de27fe41c992fb80f8dfde8658?from_recorder=1&focus_title=1

In order to replicate you need to update your DATA_CONNECTOR_URL=https://dataconnector-staging.tn.verida.tech in config.

@tahpot thanks, got it, I will try to fix that issue.

@tahpot
Copy link
Member Author

tahpot commented Jan 4, 2024 •
edited
Loading

@andy-verida will resolve conflicts and do a minor refactor.

@tahpot Needs to do a review.

@andy-verida
Copy link
Contributor

andy-verida commented Jan 4, 2024 •
edited
Loading

@tahpot I've resolved the conflicts and tested the Discord connection and it works(the SBT credential is invalid though)

Note
Need to update VERIDA_DEVNET_DATA_CONNECTOR_URL=https://dataconnector-staging.tn.verida.tech
To test data connectors with the development build
Screenshot 2024-01-04 at 19 05 17

Demo

Simulator.Screen.Recording.-.iPhone.13.-.2024-01-04.at.18.58.08.mp4

Simulator Screenshot - iPhone 13 - 2024-01-04 at 19 01 26
Simulator Screenshot - iPhone 13 - 2024-01-04 at 19 01 36

@tahpot
Copy link
Member Author

tahpot commented Jan 16, 2024

@andy-verida

The discord logo isn't appearing in the profile:

Screenshot 2024-01-16 at 11 46 22 am

@andy-verida
Copy link
Contributor

@andy-verida

The discord logo isn't appearing in the profile:

Screenshot 2024-01-16 at 11 46 22 am

@tahpot oops, I will fix that bug

@aurelticot aurelticot added this to the 1.x.x milestone Jan 31, 2024
@aurelticot aurelticot modified the milestones: 1.x.x, 1.2.0 Feb 8, 2024
@aurelticot aurelticot marked this pull request as draft February 27, 2024 10:44
@aurelticot aurelticot modified the milestones: 1.2.0, 1.3.0 Mar 7, 2024
@aurelticot aurelticot modified the milestones: 1.3.0, 1.x.x Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

1.x.x

Development

Successfully merging this pull request may close these issues.

4 participants

@tahpot @andy-verida @aurelticot