Resolve compiler warnings and upgrade to C++17#4799
Merged
Conversation
Member
Author
|
This goes with vgteam/sdsl-lite#20 in sdsl-lite. |
Contributor
|
Commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
Description
This resolves some compiler warnings, including the one about
is_podin SDSL and all the ones about inline variables being a C++17 feature.To do this, I am bumping the vg Linux C++ standard to C++17, which the Mac side already uses.
I am also removing a bunch of code for backwards compatibility to C++ standards under C++17, which wouldn't be tested anymore.
I'm also upgrading libbdsg, which introduces some new deprecation warnings from it, but I think @electricEpilith is fixing them.