Conversation
Member
|
@glennhickey @jltsiren It looks like maybe combining this with #4852 in the merge commit 2069097 somehow caused some failures in the https://github.com/vgteam/vg/actions/runs/23182304807/job/67357696590#step:7:6214 (I think we're also missing a bcftools dependency for the Mac tests, but that isn't causing this problem.) |
Member
|
Looking at the code, that doesn't make very much sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
vg describeworks better with old obsolete files.Description
vg describewill try to continue reading an identified file even when header validation fails. It also knows which versions of GBWT / GBWTGraph structures should have tags.