Skip to content

Better vg describe#4853

Merged
jltsiren merged 5 commits intomasterfrom
better-vg-describe
Mar 17, 2026
Merged

Better vg describe#4853
jltsiren merged 5 commits intomasterfrom
better-vg-describe

Conversation

@jltsiren
Copy link
Contributor

Changelog Entry

To be copied to the draft changelog by merger:

  • vg describe works better with old obsolete files.

Description

vg describe will try to continue reading an identified file even when header validation fails. It also knows which versions of GBWT / GBWTGraph structures should have tags.

@jltsiren jltsiren merged commit 2069097 into master Mar 17, 2026
2 checks passed
@jltsiren jltsiren deleted the better-vg-describe branch March 17, 2026 06:56
@adamnovak
Copy link
Member

@glennhickey @jltsiren It looks like maybe combining this with #4852 in the merge commit 2069097 somehow caused some failures in the vg deconstruct tests only in the Mac tests, and only in CI (I can't replicate it locally).

https://github.com/vgteam/vg/actions/runs/23182304807/job/67357696590#step:7:6214

not ok 32 - all nested sites found in double-nested SNP
#          got: '2'
#     expected: '3'
not ok 33 - level 2 site found in double-nested SNP
#          got: '0'
#     expected: '1'

(I think we're also missing a bcftools dependency for the Mac tests, but that isn't causing this problem.)

@adamnovak
Copy link
Member

Looking at the code, that doesn't make very much sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants