Change run loop mode to kCFRunLoopCommonMode #191
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the video rendering loop in VLCOpenGLES2VideoView to use
kCFRunLoopCommonModeinstead ofkCFRunLoopDefaultMode.Why this change is needed:
Using
CADisplayLinkwith the default run loop mode causes frame updates to pause during common UI interactions, such as pulling down the control center.This results in frozen video even though audio continues normally.
What the change does
Using
kCFRunLoopCommonModeensures frame updates even when the player is not in focus.This matches the behavior used by Apple in AVPlayer.
Testing
Tested on:
• iOS 26
• iPhone 15
Verified:
• No more rendering stalls
• No negative impact on CPU usage