Implement code coverage metrics, remove httpbin from test suite. #557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes dependency on external httpbin endpoints by switching tests to use a local proxy target, while also adjusting timeouts and response assertions to improve test reliability and code coverage metrics.
- Updated tests to use a local proxy target instead of httpbin.org
- Adjusted timeouts and refined response assertions across multiple test files
- Enhanced the sendProxyRequest logic by adding a fallback to a default implementation
Reviewed Changes
Copilot reviewed 10 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/verbs.js | Updated proxy endpoint and refined assertions for various HTTP methods |
| test/userResDecorator.js | Modified endpoints to use localhost and updated tests for response decorators and header manipulation |
| test/support/proxyTarget.js | Changed endpoints and introduced new routes; debugging code added |
| test/session.js | Updated proxy endpoint and assertions for session preservation |
| test/https.js | Refined HTTPS configuration tests using Promise-based assertions |
| test/headers.js | Adjusted header assertions with lower-case keys |
| lib/resolveOptions.js | Added support for sendProxyRequest option |
| app/steps/sendProxyRequest.js | Updated function naming and fallback mechanism |
Files not reviewed (3)
- .eslintrc: Language not supported
- .nycrc: Language not supported
- package.json: Language not supported
Comments suppressed due to low confidence (1)
test/userResDecorator.js:149
- There is a typo in the test description: 'mutuate' should be corrected to 'mutate'.
it('can mutuate an html response', function (done) {
monkpow
commented
Apr 24, 2025
test/support/proxyTarget.js
Outdated
| }); | ||
|
|
||
| target.get('/test-data', function (_, res) { | ||
| debugger; |
monkpow
commented
Apr 24, 2025
Comment on lines
+82
to
+83
| var data = JSON.parse(proxyResData.toString('utf8')); | ||
| data.funkyMessage = 'oi io oo ii'; |
There was a problem hiding this comment.
This is weird. I see that the way we're generating responses is different, but I want to re-read this more closely.
monkpow
commented
Apr 24, 2025
Comment on lines
+67
to
+69
| if (err) { return done(err); } | ||
| assert.equal(res.text, 'mypost=hello'); | ||
| done(); |
There was a problem hiding this comment.
I also like this less. Let's see if we can make that look more like the original text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.