Add support for PHP 8.4 #10928
Open
Add support for PHP 8.4 #10928
+64
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
php84
branch
7 times, most recently
from
6c0daee
to
f178309
Compare
GromNaN
commented
Apr 29, 2024
szepeviktor
reviewed
May 7, 2024
What does that mean? |
|
What's needed to move this PR forward? Is there anything I can do to help? |
szepeviktor
approved these changes
Sep 18, 2024
GromNaN
force-pushed
the
php84
branch
4 times, most recently
from
96d50f0
to
cf366be
Compare
|
Thanks for putting your time into this @GromNaN |
hafezdivandari
suggested changes
Sep 25, 2024
Merged
|
Can we get this PR merged please or anything still pending ? |
Calling new ReflectionMethod with a single argument is deprecated
JIT on AArch64 doesn't support opcache.jit_buffer_size above 128M
3 tasks
|
If anyone wants to look at the failing tests. I don't find how they are related to the changes in that PR. They are run on PHP 8.0.30. I cant reproduce in a Docker container with this PHP version. |
2 tasks
dantleech
added a commit
to phpactor/phpactor
that referenced
this pull request
Oct 12, 2024
Psalm needs to support 8.4 vimeo/psalm#10928
dantleech
added a commit
to phpactor/phpactor
that referenced
this pull request
Oct 12, 2024
* Introduce rector * Apply rector * Add 8.4 to matrix * PHPStan fixes * Revert example change * CS fix * Upgrade Twig * Upgrade twig * Fix phpstan async issue * Use PSALM PHAR in dev mode * Remove 8.4 from pipeline Psalm needs to support 8.4 vimeo/psalm#10928
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preg::replaceCallbackStrictGroupsfor PHP 8.4 compatibility composer/pcre#22