Fix invalid SARIF region for issues reported at line 0#11903
Open
eyupcanakman wants to merge 1 commit into
Open
Fix invalid SARIF region for issues reported at line 0#11903eyupcanakman wants to merge 1 commit into
eyupcanakman wants to merge 1 commit into
Conversation
An issue reported at line 0, such as UnusedBaselineEntry from a stale baseline, is written to the SARIF report with startLine 0. The SARIF schema requires region line and column values to be at least 1, so the report fails validation. The region values are now raised to at least 1. Fixes vimeo#9712
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue reported at line 0, such as
UnusedBaselineEntryfrom a stale baseline, is written to the SARIF report withstartLine0. The SARIF schema requires region line and column values to be at least 1, so the report fails validation. The region values are now raised to at least 1.Fixes #9712