Refactor SBE Command Encoding to remove ThreadLocal#26
Refactor SBE Command Encoding to remove ThreadLocal#26vincentf13 wants to merge 1 commit intomasterfrom
Conversation
Co-authored-by: vincentf13 <13410214+vincentf13@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b66aaaed9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| protected final MessageHeaderEncoder headerEncoder = new MessageHeaderEncoder(); | ||
| protected final MessageHeaderDecoder headerDecoder = new MessageHeaderDecoder(); | ||
| protected final UnsafeBuffer internalBuffer = new UnsafeBuffer(0, 0); | ||
| protected final NativeUnsafeBuffer encodeBuffer = new NativeUnsafeBuffer(256); |
There was a problem hiding this comment.
Allocating encodeBuffer in every AbstractSbeModel instance introduces new off-heap NativeUnsafeBuffer ownership, but there is no corresponding release() path (the existing ThreadContext.cleanup() only releases scratchBuffer). In services that restart worker threads (or recreate contexts), these command/report buffers remain unreleased until GC, so direct memory can accumulate across cycles and eventually hit MaxDirectMemorySize under sustained restarts.
Useful? React with 👍 / 👎.
1 participant
Refactored SBE command and report models in the
spot-inframodule to use per-instance direct memory buffers (NativeUnsafeBuffer) for encoding, replacing the previousThreadLocalbasedThreadContext.get().getScratchBuffer()approach.This increases the memory footprint per command instance slightly, but improves performance by avoiding
ThreadLocallookups and improves code readability.Changes include:
AbstractSbeModelnow initializes aNativeUnsafeBufferlocally.AuthCommand,DepositCommand,OrderCreateCommand,OrderCancelCommand) wrap this new local buffer duringencode.OrderAcceptedReport, etc.) now locally instantiate their ownExecutionReportEncoderand write to the localencodeBuffer.PR created automatically by Jules for task 13639435276955434047 started by @vincentf13