Bmdb nightly testing patch unicode#1705
Merged
Merged
Conversation
danv61
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close to one month ago, unicode support changes were pushed to VCell.
Old code that previous did not complain about poorly importing unicode suddenly started to trigger. But only in the docker image, as it turns out the base-images do not have locales installed by default. Without the
US_enlocale and subsequent default encoding of UTF-8, the JVM was deciding to use an ANSI ASCII derivative.This PR fixes the issue, and further adds a test that checks for unicode names, which ended up being where the poorly imported unicode was hiding.
Further, this PR improve error messages related to building BioModels from SBML by separating unit system construction from name-setting code.