Remove sort and plot type options from categorical attributes#593
Draft
Remove sort and plot type options from categorical attributes#593
Conversation
👷 Deploy Preview for upset2 processing.
|
- Modified getSixNumberSummary to filter out categorical attributes internally - Updated all call sites to pass columnTypes for proper filtering - Removed sort options from context menu for categorical attributes - Disabled click-to-sort for categorical attributes in AttributeButton - Added optional chaining in sortByAttribute for safer access to mean values - Added comments explaining the behavior for categorical attributes Co-authored-by: JakeWags <35744963+JakeWags@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove sort options from categorical attributes
Remove sort options and six-number summary from categorical attributes
Jan 13, 2026
Member
|
@copilot We also need to remove the "change plot" options for categorical attributes since there is only one visualization type, which already exists and cannot be changed. |
Categorical attributes only have one visualization type (stacked bar chart) and cannot be changed to other plot types like Box Plot, Dot Plot, etc. Updated AttributeButton to exclude plot type options when attribute is categorical. Co-authored-by: JakeWags <35744963+JakeWags@users.noreply.github.com>
Contributor
Author
Done in commit 40a80d9. The "Change plot type to..." options are now excluded from the context menu for categorical attributes. What changed:
Implementation: |
Copilot
AI
changed the title
Remove sort options and six-number summary from categorical attributes
Remove sort and plot type options from categorical attributes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Categorical attributes were incorrectly processed as numerical data, computing meaningless statistics (mean, median, quartiles) and offering sort-by-mean functionality in the UI. Additionally, categorical attributes had plot type change options even though they only support one fixed visualization type.
Changes
Core Package
getSixNumberSummary: AddedcolumnTypesparameter to filter out categorical attributes before computing statisticscolumnTypesthroughfirstAggregation,secondAggregation, and all helper functions (aggregateByDegree,aggregateBySets, etc.)sortByAttributeto handle missing mean values gracefullyUI Package
AttributeButton: Check attribute type viaattTypesSelectorto conditionally render options for categorical attributes:Example
Before:
After:
Context Menu Behavior
Categorical attributes (e.g., "Generation"):
Numerical attributes (e.g., "Age"):
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.