Skip to content

fix(hmr): don't mutate module graph when collecting modules #16302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 29, 2024
Merged

fix(hmr): don't mutate module graph when collecting modules #16302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite/src/node/server/hmr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ export async function handleHMRUpdate(
return
}

const mods = moduleGraph.getModulesByFile(file) || new Set()
const mods = new Set(moduleGraph.getModulesByFile(file))
if (type === 'create' || type === 'delete') {
for (const mod of getAffectedGlobModules(file, server)) {
mods.add(mod)
Comment on lines +165 to 168
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moduleGraph.getModulesByFile(file) returns a Set. mods.add(mod) mutates that Set causing the module graph to have incorrect fileToModulesMap.

Expand Down