Skip to content

Conversation

@hi-ogawa
Copy link
Contributor

Description

It looks like there's no internal test case for ssrEmitAssets but I would expect ecosystem CI would fail without this compatibility.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@hi-ogawa hi-ogawa marked this pull request as ready for review April 21, 2024 02:30
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Moved the compat code to where we are handling config.ssr so we have all in one place. We should also respect both ssrEmitAssets true and false

@patak-dev patak-dev merged commit 5c5efe4 into vitejs:v6/environment-api Apr 21, 2024
@hi-ogawa hi-ogawa deleted the fix-v6-ssrEmitAssets-compat branch April 21, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants