fix: refactor watch code for tsconfig changes to use watchChange hook #17304
+53
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
see here for an alternative approach: #17317 |
sapphi-red
force-pushed
the
v6/env-fix-tsconfck
branch
2 times, most recently
from
e503166 to
83b27a5
Compare
This reverts commit 60f90a0.
…re not modules that pass through it
sapphi-red
force-pushed
the
v6/env-fix-tsconfck
branch
from
83b27a5 to
ee6f9c8
Compare
|
closing as we merged #17317 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the refactored code had a change that caused every .json file change to trigger a full reload, this has been corrected.
For now multiple servers can still share one cache instance as the cache only contains information about tsconfig files that do not differ across environments.
Ultimately we want to have a more fine-grained invalidation when a tsconfig changes, but we would have to find out tsconfigs affected by this change (referenced from or extended by, as well as ancestors and then find all modules transpiled with any of these...)
TL;DR this is very complicated
changes to tsconfig.json should be rare enough that a full reload doesn't hurt too much.
Description