Skip to content

Conversation

@sapphi-red
Copy link
Member

Description

I simply resolved the TODO and ran the tests and it passed.
But after doing that I noticed that there's still some config references in our internal plugins, should we remove all of these before doing this PR?

if (!config.assetsInclude(cleanUrl(id)) && !urlRE.test(id)) {

@sapphi-red sapphi-red added p1-chore Doesn't change code behavior (priority) feat: environment API Vite Environment API labels Oct 23, 2024
@patak-dev
Copy link
Member

Yes, we aren't testing with sharedConfig right now. We could have an option to force it for testing locally maybe. For reference, this was added here:

@sapphi-red sapphi-red marked this pull request as draft October 24, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat: environment API Vite Environment API p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants