feat: support /children directive in aria tree template#10
Merged
hi-ogawa merged 16 commits intovitest-dev:masterfrom Mar 19, 2026
Merged
feat: support /children directive in aria tree template#10hi-ogawa merged 16 commits intovitest-dev:masterfrom
/children directive in aria tree template#10hi-ogawa merged 16 commits intovitest-dev:masterfrom
Conversation
Add tests documenting that ivya's merge layer ignores containerMode (equal/deep-equal) and always uses contain semantics. Also captures that renderAriaTemplate drops the /children directive on round-trip. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Emit `/children: equal` and `/children: deep-equal` when serializing templates. The default `contain` mode is omitted. Pseudo-prop lines are now rendered before children to match parse order. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Tests for equal, deep-equal, and contain modes including: - directive preserved on matched branch, purged on failed - deep-equal propagation to descendants - deep-equal with omitted children means "must have zero" Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
38 tasks
sheremet-va
approved these changes
Mar 19, 2026
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just remembered this wasn't implemented nor tested https://playwright.dev/docs/aria-snapshots#strict-matching.
TODO: