fix: do not throw when browser mode is used without explicit projects (#9801)#9938
Open
oilater wants to merge 4 commits intovitest-dev:mainfrom
Open
fix: do not throw when browser mode is used without explicit projects (#9801)#9938oilater wants to merge 4 commits intovitest-dev:mainfrom
oilater wants to merge 4 commits intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
sheremet-va
reviewed
Mar 22, 2026
| if (this._cliOptions.browser?.enabled) { | ||
| const browserProjects = this.projects.filter(p => p.config.browser.enabled) | ||
| if (!browserProjects.length) { | ||
| if (!browserProjects.length && !this.config.browser?.instances?.length) { |
Member
There was a problem hiding this comment.
This should not be needed because instances inject new projects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #9801
This PR fixes an issue where Vitest throws an incorrect validation error when browser mode is enabled without an explicit
config.projects, even if validbrowser.instancesare provided.Implementation
Updated the browser validation logic to distinguish between workspace and non-workspace configurations.
config.projectsis not defined, browser mode is allowed as long as validbrowser.instancesare provided.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.