fix: resolve retry.condition RegExp serialization issue#9942
Open
nstepien wants to merge 1 commit intovitest-dev:mainfrom
Open
fix: resolve retry.condition RegExp serialization issue#9942nstepien wants to merge 1 commit intovitest-dev:mainfrom
retry.condition RegExp serialization issue#9942nstepien wants to merge 1 commit intovitest-dev:mainfrom
Conversation
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
hi-ogawa
reviewed
Mar 22, 2026
| }) | ||
|
|
||
| it('test.retry.condition is corrrectly serialized', async () => { | ||
| const { stderr, results } = await runInlineTests({ |
Collaborator
There was a problem hiding this comment.
We don't use runInlineTests inside test/core. The integration level test should go to test/cli. (context #9434)
Side note: the error below is because Vite 8 (rolldown) inside vmThreads doesn't work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test.retry.conditionsetting was not de/serialized correctly in browser tests.This should resolve it.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.