driver: fix vfmt of the module cache condition - #28953
Merged
Merged
Conversation
d36d94a put a comment in the middle of the `cache_candidate_enabled` `&&` chain, leaving a trailing `&&` that vfmt rewrites as `&& ` (trailing space). That fails `v fmt -verify` in the macOS CI jobs. Move the comment above the declaration and keep the leading-`&&` style used by the rest of the chain. The condition is unchanged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
v fmt -verifyfailure in theclang-macos(macos-14/15/26) jobs on master:https://github.com/vlang/v/actions/runs/36102137480/job/107966700948
d36d94a put a comment in the middle of the
cache_candidate_enabled&&chain. That left a trailing&&, which vfmt rewrites as&&(with a trailing space).This PR moves the comment above the declaration and keeps the leading-
&&style used by the rest of the chain. The condition is unchanged.Verified locally:
./v fmt -inprocess -verify vlib/v/driver/driver.vpasses./v fmt vlib/v/driver/driver.voutput matches the file exactly./v selfbuilds