fix(buildkite): remove evaluation of untrusted local python scripts#367
Open
jcc-google wants to merge 2 commits into
Open
fix(buildkite): remove evaluation of untrusted local python scripts#367jcc-google wants to merge 2 commits into
jcc-google wants to merge 2 commits into
Conversation
Remove the WIP feature in bootstrap-amd.sh that unconditionally executes .buildkite/pipeline_generator/pipeline_generator.py from the untrusted pull request checkout workspace, preventing arbitrary code execution on CI runner instances. All standard vLLM pull requests and nightly workflows use the established Jinja templating engine (test-template-amd.j2), so this code block is completely unused by standard jobs. Signed-off-by: Jincheng Chen <chenjincheng@google.com> BUG=b/510375628 TAG=agy CONV=b0c467aa-15c4-4a1c-90eb-dd47e74ade75
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the WIP feature in bootstrap-amd.sh that unconditionally executes .buildkite/pipeline_generator/pipeline_generator.py from the untrusted pull request checkout workspace, preventing arbitrary code execution on CI runner instances.
All standard vLLM pull requests and nightly workflows use the established Jinja templating engine (test-template-amd.j2), so this code block is completely unused by standard jobs.
Signed-off-by: Jincheng Chen chenjincheng@google.com
BUG=b/510375628
TAG=agy
CONV=b0c467aa-15c4-4a1c-90eb-dd47e74ade75